pinax/pinax-documents

Rewrite views as class based views

paltman opened this issue · 1 comments

paltman commented

Currently there is a mix of function and class-based views. We should ship with CBVs to allow for greater extensibility.

  • folder_create => FolderCreateView(LoginRequiredMixin, CreateView)
  • folder_detail => FolderDetailView(LoginRequiredMixin, DetailView)
  • document_create => DocumentCreateView(LoginRequiredMixin, CreateView)
  • document_detail => DocumentDetailView(LoginRequiredMixin, DetailView)
  • document_download => DocumentDownloadView(LoginRequiredMixin, View) (but maybe a DetailView)
  • folder_share => FolderShareView(LoginRequiredMixin, View) (but maybe a DetailView)
  • document_delete => DocumentDeleteView(LoginRequiredMixin, DeleteView)
grahamu commented

@paltman Is this issue now resolved?