ping/odmpy

Latest change breaks chapters for some books

Diegus83 opened this issue · 2 comments

I tried the latest commit that removes the dependency for eyeD3 and it breaks the chapters function for this particular book: Ball Lightning by Cixin Liu
I think it might have something to do with the special characters in the names of some chapters (@, / ).

I tried other three books with regular characters (a-z, :, -) in the names and it worked fine.

**Chapters generated with 0.3.0**
00:00:00.000 Ball Lightning
00:00:37.988 Prelude
00:13:57.988 Part 1 - College
00:20:10.988 Part 1 - Strange Phenomena 1
00:30:12.988 Part 1 - Ball Lightning
00:58:15.981 Part 1 - Lin Yun 1
01:19:37.981 Part 1 - Zhang Bin
01:44:09.981 Part 1 - Strange Phenomena 2
01:50:22.342 Part 1 - A Bolt from the Blue
02:44:42.342 Part 1 - Seti@home
03:05:49.101 Part 1 - Siberia / Part 2 - Lighthouse Inspiration
04:16:13.545 Part 2 - General Lin Feng
04:34:22.545 Part 2 - Attack Bees
04:41:06.545 Part 2 - Skynet
05:13:31.545 Part 2 - Ball Lightning
05:20:51.545 Part 2 - Thunderballs
05:29:19.870 Part 2 - Ding Yi
05:43:27.870 Part 2 - Empty Bubbles
06:21:54.870 Part 2 - Macro-Electrons
06:34:23.766 Part 2 - Weapons
07:02:16.766 Part 2 - Observers
07:16:22.766 Part 2 - Burnt Chips
07:28:07.766 Part 2 - Strange Phenomena 3
07:33:24.403 Part 2 - The Nuclear Power Plant
08:07:15.403 Part 2 - Strange Phenomena 4
08:23:02.403 Part 3 - Tornadoes
08:37:37.020 Part 3 - Zhufeng
08:51:34.020 Part 3 - Chip Destruction
09:03:39.020 Part 3 - Ambush at Sea
09:52:43.639 Part 3 - Strings
10:19:18.639 Part 3 - The Special Leading Group
10:41:36.639 Part 3 - Macro-Fusion
10:59:45.033 Part 3 - Lin Yun 2
11:40:36.033 Part 3 - Victory
11:48:19.033 Part 3 - The Quantum Rose
12:04:18.033 Afterword
12:11:27.033 Closing
**Chapters generated with 0.4.0**
00:00:00.000 Prelude
12:11:27.033 Closing
12:11:27.034 Afterword
12:11:27.035 Ball Lightning
12:11:27.036 Part 2 - Skynet
12:11:27.037 Part 1 - College
12:11:27.038 Part 2 - Ding Yi
12:11:27.039 Part 2 - Weapons
12:11:27.040 Part 3 - Zhufeng
12:11:27.041 Part 3 - Strings
12:11:27.042 Part 3 - Victory
12:11:27.043 Part 1 - Lin Yun 1
12:11:27.044 Part 1 - Zhang Bin
12:11:27.045 Part 1 - Seti@home
12:11:27.046 Part 2 - Observers
12:11:27.047 Part 3 - Tornadoes
12:11:27.048 Part 3 - Lin Yun 2
12:11:27.049 Part 2 - Attack Bees
12:11:27.050 Part 2 - Burnt Chips
12:11:27.051 Part 2 - Thunderballs
12:11:27.052 Part 3 - Macro-Fusion
12:11:27.053 Part 2 - Empty Bubbles
12:11:27.054 Part 3 - Ambush at Sea
12:11:27.055 Part 1 - Ball Lightning
12:11:27.056 Part 2 - Ball Lightning
12:11:27.057 Part 2 - Macro-Electrons
12:11:27.058 Part 2 - General Lin Feng
12:11:27.059 Part 3 - Chip Destruction
12:11:27.060 Part 3 - The Quantum Rose
12:11:27.061 Part 1 - Strange Phenomena 1
12:11:27.062 Part 1 - Strange Phenomena 2
12:11:27.063 Part 2 - Strange Phenomena 3
12:11:27.064 Part 2 - Strange Phenomena 4
12:11:27.065 Part 1 - A Bolt from the Blue
12:11:27.066 Part 2 - The Nuclear Power Plant
12:11:27.067 Part 3 - The Special Leading Group
12:11:27.068 Part 1 - Siberia / Part 2 - Lighthouse Inspiration

The debug information list the chapters in the correct order in both cases.
debug v030.txt
debug v040.txt

ping commented

Thanks for the report.

Spent more time trying to debug this than the actual porting over to mutagen from eyed3.
I've decided to revert back to using eyed3 until I have more time to look at this.

ping commented

Closing this since the revert back to eyed3 has fixed the issue.