pingswept/pysolar

Inverted documentation for azimuth.

lvella opened this issue · 2 comments

Besides issue #75, azimuth's documentation seems at odds with the program: it says south is zero, but retrieving the azimuth for noon at a southern hemisphere point with solar.get_azimuth(-18.9132481, -48.2584742, noon), will give me a value around zero, but it is expected a value around 180, since sun's arc is around north for southern hemisphere.

What is the correct interpretation of the value returned by solar.get_azimuth()?

I did a comparison with PyEphem, and solar.get_azimuth() uses the same reference system as they do, i.e., azimuth measured at east of north (which would make PySolar documentation wrong?).

Maybe someone changed the reference direction in solar.get_azimuth(), but forgot to update the documentation and solar.get_azimuth_fast(), leading to this and issue #75 ?

Seems like the azimuths on master correspond to the standard definition (clockwise from north, as in other ephemeris libraries), whereas the azimuths on the latest version available on pypi are different (probably match the definition that is in the docs).
Supposing we fix the docs, is there anything else blocking release of next version to pypi (I need the standard azimuths, so right now cannot use the latest release...)