Missing TypeScript types

Question

Missing TypeScript types

kibertoad opened this issue 3 years ago · 6 comments

Answer 1 · 2021-07-04T10:36:23.000Z

@mcollina Is it too early to add types? How much breaking API changes are expected in this package in the nearby future?

Answer 2 · 2021-07-04T13:13:29.000Z

go for them!

Answer 3 · 2022-03-18T20:13:33.000Z

I'm adding a minimal version of types in this draft PR #71 , but I only added them because I needed types for testing a fix. They're not exposed in the package.json file, nor refined enough.

I prefer to not overdo them for this PR, but I could prepare a second one with a refined version, and expose them properly.

Answer 4 · 2024-08-21T07:32:39.000Z

@mcollina I noticed that ThreadStream (the return type of transport(..)) is any. Is there a reason we do not just set it to be DestinationStream? That would match with what pino(options: ... , stream: DestinationStream) expects.

Answer 5 · 2024-08-31T14:51:54.000Z

Because it's not.

Answer 6 · 2024-10-23T16:44:45.000Z

@magnusriga thanks with the DestinationStream hint, helped me to fix the any warning 👍🏻