pipermerriam/ethereum-function-signature-registry

Ignoring functions/events with missing parameter name

a5net opened this issue · 1 comments

a5net commented

What is wrong?

I just realized that Solidity also accepts functions/events with the missing parameter names (just like in C++). However, I am not sure if such a case should be taken into account, because it is quite rare.

The following code is an example that contains function and event that are accepted and compiled in Solidity, however, the import from the source code file ignores both of them.

pragma solidity >=0.4.22 <0.7.0;

contract Bar {
    
    function fooFunction(uint) public { }
    event fooEvent(uint);
}

How can it be fixed

Possibly, we would need to rewrite the regex that catches functions and events.

I'm in favor of pushing to get the current changes finished and released before addressing this (unless it proves to be really easy)