VIN - Binary result returned

Question

VIN - Binary result returned

KirbyJames opened this issue 9 years ago · 19 comments

Hi, I've rebuilt android-obd-reader-2.0-RC3 which I think contains obd-java-api-master 1.0-RC15 or RC14.

After looking at earlier VIN related prblems I've added ATH0 to the initialisation string. However I still get (a fixed) binary value displayed for the VIN (except on about 1 in 10 occsaions when it does display the correct value).

I'd be grateful for any pointers as to what I might be doing wrong.

pires commented 8 years ago

Done.

Answer 1 · 2016-05-09T08:51:13.000Z

This is still an issue on my side as well. I am prepared to put up a $10 reward for a proper fix for the VIN.

Answer 2 · 2016-05-09T11:01:37.000Z

Add $10 from me

Sent from my iPhone

On May 9, 2016, at 4:51 AM, Pho3niX90 notifications@github.com wrote:

This is still an issue on my side as well. I am prepared to put up a $10 reward for a proper fix for the VIN.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

Answer 3 · 2016-05-10T07:24:28.000Z

For all that are having this issue, please post your rawData vin here. I need to see what vins are being returned so that I can figure out one algorithm.

Answer 4 · 2016-05-11T10:49:51.000Z

Many thanks for returning to this issue.

Below are two VINs shown as both raw and hex

euÂ¥Â¥Â£ÂµÂ¤ #3s#                               
eÂ…Â„Ã”Â£ £ÂƒSs

Answer 5 · 2016-05-11T10:50:50.000Z

Many thanks for returning to this issue.

Below are two VINs shown as both raw and hex

euÂ¥Â¥Â£ÂµÂ¤ #3s#
eÂ…Â„Ã”Â£ £ÂƒSs

Answer 6 · 2016-05-11T12:22:09.000Z

@KirbyJames
Could you please post your raw response from the obd. So that I can do tests?

Answer 7 · 2016-05-11T12:46:16.000Z

@KirbyJames Pleaes try this project: http://goo.gl/uAcCK3
Replace the result string with your raw response. See if it's giving you the correct output

Answer 8 · 2016-05-11T15:24:25.000Z

Hi, I've added the code to VinCommand.java and rebuilt the app. Unfortunately it returns the same value ..

Answer 9 · 2016-05-11T15:40:03.000Z

@KirbyJames I will need your rawData response to rrsolve.

Answer 10 · 2016-05-11T15:40:53.000Z

in calculated results. Instead of returning vin return rawData

Answer 11 · 2016-05-11T16:02:33.000Z

@KirbyJames
Please add the following in you vin data
Log.d("VinCommand.java", "rawdata: " + rawData);

Like so:

Then find the raw response in your logcat.

Answer 12 · 2016-05-11T18:00:14.000Z

Ah. I have realised that my build is using the github version of obd-java-api-master/. I have downloaded the obd-java-api-master library - but I don't know how to modify the gradle configuration to use it in the build.

Answer 13 · 2016-05-11T18:52:27.000Z

@KirbyJames I have no idea to be honest. I have completely moved away from gradle.
@pires do you know the answer to the above question?

Answer 14 · 2016-05-11T20:00:50.000Z

I've managed to re-build the app with the modified VinCommand.java
I've printed the rawdata value below ... and a valid 17-character Vin is returned :-)

rawdata: 0:4902015756571:5A5A5A314B5A422:57323233373237
Vin: WVWZZZ1KZBW223727

Answer 15 · 2016-05-11T20:15:22.000Z

@KirbyJames Awesome news! What vehicle was it used in, which country and what year model is the vehicle? This will help greatly in diagnosing further enchancements to the VIN.

Answer 16 · 2016-05-11T21:27:52.000Z

WVWZZZ1KZBW223727 is a 2011 VW Golf registered in the UK.
Will the update be included in an updated obd-java-api?

Answer 17 · 2016-05-11T21:45:57.000Z

Then it's most def a can. on same restriction as we here in south africa are, except no emissions.
Anyways, yes the changes will be added to the lib, pullrequest is located here -> pires/obd-java-api#113

Answer 18 · 2016-05-12T11:51:06.000Z

I'll be releasing library RC16 as soon as @Pho3niX90 finishes an open PR and will update this project.