pires/android-obd-reader

Add Mode 22 Support

malibu1320 opened this issue · 6 comments

malibu1320 commented

Would be nice to work on adding mode 22 support for enhanced PID's. I can assist.

pires commented

Please, go ahead. github.com/pires/obd-java-api is where it should be implemented.

malibu1320 commented

Do you have any guidance on what needs to be modified? I'm not seeing where the base request header is setup that needs changed. I have the source running locally and connected to my bench PCMs.

pires commented

Share here what you have and I'll take a look.

  • 🎉1
malibu1320 commented

Here's an example for GM vs standard OBD. You request on mode $22 with PID "119D". Now I need to see where to adjust analyzing the buffer for a valid response.

public BarometricPressureCommand() {super("01 33");} //Standard OBD PID
public GMBarometricPressureCommand() {super("22 11 9D"); //GM Mode $22 PID
malibu1320 commented

@pires , do you have any tips on how I can implement this? I tried adding new command classes as seen above and adjusting the buffer offset for finding the data but didn't have any luck (yet).

pires commented

Just override fillBuffer or readRawData, depending on your needs.