Doesn't work
pintassilgo opened this issue · 7 comments
Only regex seems to work. Migemo doesn't find anything, can't find "Frédéric" nor "frederic" within extension page (https://addons.mozilla.org/en-US/firefox/addon/xulmigemo/). And "highlight all" doesn't work even in regex mode.
And always asks for disctionary on start, even after properly download it at previous session.
Firefox 46.0.1, just XULMigemo and "Addon Manager with Profiling" activated.
Sorry, regression on 0.14.0. I've fixed the problem on en-US mode at 0.14.1 and it is already released.
Now is working fine, thank you.
- It would be possible to make it compatible with Findbar Tweak? Mainly because of markers in scroll bar.
- Even disabling "xulmigemo.scrollSelectionToCenter.smoothScroll.enabled", next/previous is slow in relatively long pages (e.g. long articles on Wikipedia), sometimes spending more than 1s to return each word (using Normal Find it's always instant). Is this a natural limitation? (edit: apparently no, because Fastest Search addon works in a similar way and has no delay - but it's more intrusive, I would like to use XUL/Migemo)
New bug (it would be better to open a new issue?):
Can't search in History Library/Places (Ctrl+Shift+H), type into input box does nothing. But History sidebar (Ctrl+H), Bookmarks sidebar (Ctrl+B) and Bookmarks Library/Places (Ctrl+Shift+B) seem to work.
Doesn't work in Spotify Web Player.
Please report one report per one issue, to track which problem is fixed and which is not yet.
Even disabling "xulmigemo.scrollSelectionToCenter.smoothScroll.enabled", next/previous is slow in relatively long pages (e.g. long articles on Wikipedia), sometimes spending more than 1s to return each word (using Normal Find it's always instant). Is this a natural limitation?
Maybe yes. XUL/Migemo provides flexible search by following steps:
- Generate a regular expression from input.
- Collect visible text from the search range.
- Collect terms matching to the regular expression from the text.
- Find matched terms from the search range.
The most slow step is 2. To avoid matching to invisible text (in collapsed sections, etc.) we have to check visibility of a text node for each.
Can't search in History Library/Places (Ctrl+Shift+H), type into input box does nothing. But History sidebar (Ctrl+H), Bookmarks sidebar (Ctrl+B) and Bookmarks Library/Places (Ctrl+Shift+B) seem to work.
It seems to be fixed on the master.