pitchmuc/adobe-analytics-api-2.0

Stick to one quotation style

Closed this issue · 4 comments

Ryuno-Ki commented

Normally, you are using single quotes for your dictionaries.
Why do you switch to double ones in https://github.com/pitchmuc/adobe_analytics_api_2.0/blob/04e29001025a6440e972efe6b1b9f292aac956a8/adobe_analytics_2/aanalytics2.py#L81-L85 and following?

pitchmuc commented

Honest response : probably because I coded it on a different day with less python and more JS (where I am more used to use double quotation there).
That is a good point for consistency.

  • 👍1
  • 😄1
Ryuno-Ki commented

I know what you mean :-D

But a linter can be your friend here ;-)
Or let black do the boring stuff for you.

pitchmuc commented

Yes. I feel the important tip there.
I definitely need to do some black magic before releasing my stuff.
I started to work on my new project with someone else and he is a black user... it takes time to get used to tat formatting.
Let's say it is for the greater good :)

pitchmuc commented

I finally used black to format my file. :)
I will close that one.

  • 👍1