Verify if version.py is necessary
Closed this issue · 2 comments
It's unclear if version.py is necessary for integrating with JupyterHub. We should confirm whether it is. If not, remove the file and put the version directly in the package __init__.py file.
version.py only provides the version number for our github repo "Jupyter-Authenticator". This number is just for version control of our remote user custom authenticator class on Github.
It doesn't have to do with the Python version used by JupyterHub, which should be the same in both the Hub and single-user instances.
So the number in version.py is not related to anything else JupyterHub is doing. We can remove the file and put the version directly in the __init__.py file.
It doesn't have to do with the Python version used by JupyterHub
I'm not too worried about the Python compatibility. I was more concerned if the version.py file was provided as an entry point for JupyterHub to track plugin versions. I didn't see an API specification in the JupyterHub docs to indicate the file was necessary, but the file's inclusion felt like a strange architectural decision.
We can remove the file and put the version directly in the init.py file
Great, I'll make the necessary changes.