Make web pack compatible.

Question

Make web pack compatible.

giodamelio opened this issue 7 years ago · 7 comments

I have been wanting to use cowsay in the web browser for awhile now. There is a fork of this package makes it work, but the docs are not good, and it seems to me that it would be better to make it work on the upstream version.

I was wondering if you would be willing to accept a patch that refactors the loading of the cows to not use any node apis? I was thinking of converting the cow files into json, and writing a build script to convert the original versions to json versions. Should be relatively easy and work seamlessly on both Node.js and in the browser with something like Webpack or Browserify. Creating UMD bundles would also be a possibility.

Answer 1 · 2017-08-02T02:31:36.000Z

holy cow! I didn't expect people would use this module in a browser.

Sure it sounds like a good idea, well, as good as using cowsay in node. Let me find some time to think about it. Is it necessary to convert to JSON? Webpack has a plain text loader as well

Answer 2 · 2017-08-02T02:37:15.000Z

That's a good point! I've never played around with it, but I don't see any reason it wouldn't work. Just to let you know, the reason I and many other people are using it is that is has become part of the ciriculum at a coding bootcamp called Code Fellows, we use it in a bunch of assignments on both the back end and front end. A whole lot of people have use it to write basically the first Node server they have ever written. It's pretty cool 😀

…

On Tue, Aug 1, 2017, 7:31 PM Fabio Crisci ***@***.***> wrote: holy cow! I didn't expect people would use this module in a browser. Sure it sounds like a good idea, well, as good as using cowsay in node. Let me find some time to think about it. Is it necessary to convert to JSON? Webpack has a plain text loader as well — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#25 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAa9LgmP0fgvndBIC07NH4ktgmNFWjv2ks5sT9-IgaJpZM4OkX50> .

Answer 3 · 2017-08-15T09:26:55.000Z

@giodamelio Do you have time to check the branch browser and see if it works on your setup?

Answer 4 · 2017-08-17T02:53:51.000Z

It works great. I didn't know webpack would use the browser field first!

One thing though, the browser.js is not exporting a default which breaks some code.

Adding export default { say, think }; to the end of the file fixes it up just fine.

Thanks so much for doing this, I have to go look into rollup too now, seems pretty nice.

Answer 5 · 2017-08-17T05:19:43.000Z

One thing though, the browser.js is not exporting a default which breaks some code.

What code is broken? I wanted to avoid having both a default and named exports

Answer 6 · 2017-08-25T03:09:00.000Z

Version 1.2.0 works in the browser

Answer 7 · 2017-08-25T03:25:56.000Z

Awesome, thanks so much for making this happen.

…

On Thu, Aug 24, 2017, 8:09 PM Fabio Crisci ***@***.***> wrote: Version 1.2.0 works in the browser — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#25 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAa9LsoXJDxmhZmYBP_9bmNv1HRNb-Qqks5sbjrNgaJpZM4OkX50> .