domain names created with env name
fredwangwang opened this issue · 7 comments
The DNS entries that are being created include the env name in them. In previous implementations fo the azure terraforming, the user could provide the base domain, and prefixes for subsequent supported domains (ie custom sub domains for PCF, Opsman, etc).
We'd like to discuss removing the env name from the DNS entries.
-- @jtarchie && @fredwangwang
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.
The labels on this github issue will be updated when the story is started.
Since the other iaases prefix the dns zone and records with the environment name, we could accept a PR that introduces a new variable for a configurable dns zone name for azure. Since all the records are created and bound to the zone created here (https://github.com/pivotal-cf/terraforming-azure/blob/master/dns.tf#L2), we could allow the name of the zone to be configurable so that it doesn't force the domain to contain the environment name.
Does that sound good?
I think so. We might have to discuss some more customization around the names of the subdomains, too. Some people have require customization of the subdomain, so that it follows some internal naming convention.
Are you still interested in this feature? Would you be willing to submit a PR if so?
This would be a good feature to have. @rowanjacobs the ask is for a new parameter for DNS names, yeah?
That sounds correct.
@rowanjacobs see #24.
//cc @jtarchie @fredwangwang