pivotal-cf/terraforming-azure

Invalid XML when creating opsmanagerimage

skmichaelson opened this issue · 2 comments

skmichaelson commented

We're noticing an invisible character being added to the beginning of our XML file for creating zurerm_storage_container.ops_manager_storage_container. We don't know if this is an issue with our usage or a bug in this repo.

We're using a docker image for terraform: ljfranklin/terraform-resource@0.11.14�.

As a side note, terraforming-aws and terraforming-gcp works for us with no issues.

1 error occurred:
	* module.ops_manager.azurerm_storage_container.ops_manager_storage_container: 1 error occurred:
	* azurerm_storage_container.ops_manager_storage_container: Error creating Container "" (Account "ulpv8lqorij34bk16yoc" / Resource Group "leather-snapper"): containers.Client#Create: Failure responding to request: StatusCode=403 -- Original Error: autorest/azure: error response cannot be parsed: "\ufeff<?xml version=\"1.0\" encoding=\"utf-8\"?>\n<Error><Code>AuthenticationFailed</Code><Message>Server failed to authenticate the request. Make sure the value of Authorization header is formed correctly including the signature.\nRequestId:d1da942b-c01c-0068-454e-42c3df000000\nTime:2019-07-24T18:33:09.9798730Z</Message></Error>" error: invalid character 'ï' looking for beginning of value
skmichaelson commented

This may be related to the following deprecation warnings:

Warning: module.infra.azurerm_storage_container.bosh_storage_container: "resource_group_name": [DEPRECATED] This field has been deprecated and is no longer used - will be removed in 2.0 of the Azure Provider

Warning: module.infra.azurerm_storage_container.stemcell_storage_container: "resource_group_name": [DEPRECATED] This field has been deprecated and is no longer used - will be removed in 2.0 of the Azure Provider

Warning: module.infra.azurerm_storage_table.stemcells_storage_table: "resource_group_name": [DEPRECATED] This field has been deprecated and is no longer used - will be removed in 2.0 of the Azure Provider

Warning: module.infra.azurerm_subnet.infrastructure_subnet: "network_security_group_id": [DEPRECATED] Use the `azurerm_subnet_network_security_group_association` resource instead.

Warning: module.ops_manager.azurerm_storage_container.ops_manager_storage_container: "resource_group_name": [DEPRECATED] This field has been deprecated and is no longer used - will be removed in 2.0 of the Azure Provider
ciphercules commented

Hi @skmichaelson, thanks for bringing this to our attention. The deprecation warnings are a bit of a red herring, as they're really about getting the templates ready to support the Azure provider version 2.0, which hasn't been released yet.

We discovered that we were getting permissions issues trying to create the storage account as a Premium account, so we switched to standard:

resource "azurerm_storage_account" "ops_manager_storage_account" {
  name                     = "${random_string.ops_manager_storage_account_name.result}"
  resource_group_name      = "${var.resource_group_name}"
  location                 = "${var.location}"
  account_tier             = "Standard"
  account_replication_type = "LRS"

  tags = {
    environment = "${var.env_name}"
    account_for = "ops-manager"
  }