pkg/profile

Using MemProfileAllocs sample in the readme

bitcodr opened this issue · 1 comments

bitcodr commented

In the readme, there is an example which is shows how to use profile.MemProfileAllocs in the Start function, but the sample is wrong and you'll get an error like

cannot use profile.MemProfileAllocs (type func() func(*profile.Profile)) as type func(*profile.Profile) in argument to profile.Start

And the readme should be
p := profile.Start(profile.MemProfileAllocs(), profile.ProfilePath("."), profile.NoShutdownHook)

So if do you confirm it's wrong can I send a PR to fix the readme or the codebase?

davecheney commented

Opps. Thanks for spotting that. Fix coming up

  • 👍1