Versioning and breaking change in `MemProfile{Heap,Allocs}` signatures

Question

Versioning and breaking change in `MemProfile{Heap,Allocs}` signatures

Closed this issue 4 years ago · 4 comments

mmcloughlin commented 4 years ago

Commit 3704c8d changed the signatures of MemProfile{Heap,Allocs}. Is this going to require a v2?

Answer 1 · 2021-05-05T03:01:37.000Z

If it did, i'm sorry, but I'm not going to do the v2 nonsense. Sorry.

Answer 2 · 2021-05-05T03:06:55.000Z

Not a problem, I was just curious how you intended to handle it.

Answer 3 · 2021-05-05T03:44:51.000Z

Thanks for catching it. It’s hard to remember back a year but if I did spot the comparison break, which I probably didn’t, I would have said “nah, not worth v2”. This is probably still true.

Answer 4 · 2021-05-05T03:46:41.000Z

Yeah I think you're fine. I assume very few are affected and the fix is removing parens (). But you'd minimize the impact by tagging v1.6.0 now.