Step can fail but action can still return as passing

[Trott]

Ref: https://github.com/nodejs/github-bot/actions/runs/4354160252

[Trott]

I guess this might be intentional?

action/.github/workflows/node-test.yaml

Line 184 in 065c6b2

continue-on-error: true

[ljharb]

Yes, because npm ls will fail if the dep graph is invalid, and many projects' dep graphs are sadly invalid.

Note that the installation itself failing should still fail the job; only the npm ls step has continue-on-error.