pkgjs/parseargs

linter: our linter is missing some rules from the Node.js codebase

bcoe opened this issue · 3 comments

bcoe commented
  • requirement of using errors.js, vs., new Error.
  • expectation of object vs., array destructuring.

Refs: #89

shadowspawn commented

Our current dependency is:

    "eslint-plugin-node-core": "iansu/eslint-plugin-node-core",
shadowspawn commented

#17 was closed when @iansu found https://github.com/nodejs/eslint-plugin-nodejs-internal had been created.

(node-core-test is looking at using same linter and rules too: nodejs/node-core-test#22 )

iansu commented

As far as I know nodejs/eslint-plugin-nodejs-internal is an exact copy of iansu/eslint-plugin-node-core. I just double checked and that repo still only has the one original commit. I can look at making a PR to update the nodejs version with whatever is in core (if there are changes) and then make a PR switching parseargs over to that.

  • 👍1