pkiraly/qa-catalogue

Align default input und output directory paths in docker container and on the host

Phu2 opened this issue · 0 comments

Phu2 commented

In Dockerfile lines 64-65

 && sed -i.bak 's,BASE_INPUT_DIR=./input,BASE_INPUT_DIR=/opt/qa-catalogue/marc,' /opt/qa-catalogue/setdir.sh \
 && sed -i.bak 's,BASE_OUTPUT_DIR=./output,BASE_OUTPUT_DIR=/opt/qa-catalogue/marc/_output,' /opt/qa-catalogue/setdir.sh \

default paths are changed, i wonder why?
I'd suggest using the same paths on the host and inside the container for consistency.

In docker-compose.yml line 9

- ./${INPUT:-input}:/opt/qa-catalogue/marc

only the input path is mapped, output files are saved in ./input/_output/ directory on the host. Which is somewhat confusing.
I'd suggest

      - ./${INPUT:-input}:/opt/qa-catalogue/input`
      - ./${OUTPUT:-output}:/opt/qa-catalogue/output`