pkp/healthSciences

Reviewing interests "tagit" results not styled properly on registration

Closed this issue · 9 comments

When you enter reviewing interests under user/register, there is a search results div that gets added as soon as you type in that field. But it appears at the very bottom of the page, where it will say "No search results." which looks weird appearing after the footer. I am assuming it's supposed to appear directly below the input, or not at all.

Yes, it probably should be hidden. @sssoz can you take a look?

sssoz commented

@dalemoore - I am trying to reproduce this issue and I’m not able to.

Can you send me a screenshot? Here’s what I am seeing:

b5b158719320aff555d8f88938f3bcdb

Sure, here you go. We created a completely custom child theme of the Health Sciences theme, but I switched it back to the Health Sciences theme itself to demonstrate/screenshot as I used CSS to manually hide it in the child theme.

nosearchresults

sssoz commented

It’s being added in the HTML, but doesn’t appear on the page? I’ve checked in other themes, and I can see that it’s also being added there:

Screen Shot 2019-06-14 at 14 09 47

If that’s the issue, don’t think it’s related to the theme - but I’ll keep checking.

sssoz commented

@dalemoore This is an issue appearing in all other themes -- I’ve moved it to OJS core, if you’d like to follow up on it there: pkp/pkp-lib#4830

Closing this one here.

@sssoz to fix this, you'll need to apply some styles to each theme where it is effected. You can see @thinkbulecount2's solution in the PR here: https://github.com/pkp/ojs/pull/2444/files

Pull Request would anyone be able to review? @Vitaliy-1 or @sssoz ?

Hey sorry so I'm back on this!! Sorry for the delay

Looks like resolved, closing.