Unexpected report on `String#replace`

Question

Unexpected report on `String#replace`

Closed this issue 2 years ago · 13 comments

Version(if relevant): 2.18.0

Environment(if relevant):

Code(if relevant):

const camelCase = (val: string) =>
  val.replace(/-([\da-z])/g, ([_, $0]) => $0.toUpperCase())

Expected:

No report

Actual:

scripts/build.ts:45:32: _
scripts/build.ts:45:35: $0
scripts/build.ts:45:43: $0
scripts/build.ts:45:46: toUpperCase
154 / 158 97.46%

See ts playground

Answer 1 · 2021-08-14T07:34:37.000Z

your string. replace's type definition is at lib.es2015.symbol.wellknown.d.ts, you can check whether your -p tsconfig.json contains ES2015.

Answer 2 · 2021-08-14T07:45:11.000Z

@plantain-00

My tsconfig:

{
  "extends": "@1stg/tsconfig/lib"
}

It is using "lib": ["ESNext"] inside.

Answer 3 · 2021-08-14T08:13:52.000Z

What I tried:

{
  "extends": "@1stg/tsconfig/lib" // no error from type-coverage and vscode's typescript@4.3.5
}

{
  "extends": "@1stg/tsconfig/lib",
  "compilerOptions": {
    "target": "es5" // errored from type-coverage and vscode's typescript@4.3.5
  }
}

{
  "extends": "@1stg/tsconfig/lib",
  "compilerOptions": {
    "target": "es5",
    "downlevelIteration": true // no error from type-coverage and vscode's typescript@4.3.5
  }
}

Answer 4 · 2021-08-14T08:19:29.000Z

@plantain-00 Wired, can you please try https://github.com/JounQin/remark-preset-prettier/tree/fix/esm for reproduction? (Branch fix/esm)

remove line https://github.com/JounQin/remark-preset-prettier/blob/fix/esm/scripts/build.ts#L45

yarn && yarn build && yarn typecov

Answer 5 · 2021-08-14T08:37:53.000Z

I remove the // type-coverage:ignore-next-line -- https://github.com/plantain-00/type-coverage/issues/96 and get

$ yarn typecov
yarn run v1.22.4
$ type-coverage
158 / 158 100.00%
type-coverage success.
✨  Done in 4.76s.

Answer 6 · 2021-08-14T08:42:07.000Z

Maybe your error comes from the cached result, try to delete .type-coverage and do it again.

Answer 7 · 2021-08-14T09:09:47.000Z

I've tried to delete .type-coverage a lot of times.🤣

Answer 8 · 2021-08-14T09:15:07.000Z

OK, I found that it results 100% on Node 14 while lower on Node 12.

Answer 9 · 2021-08-14T09:24:46.000Z

That is very weird, after reinstall node 12 via nvm install 12, there is no issue...

Close for now.

Answer 10 · 2021-08-14T09:27:35.000Z

...

See https://github.com/JounQin/remark-preset-prettier/runs/3328501669#step:8:29

Or https://github.com/JounQin/remark-preset-prettier/actions/runs/1130254010

All node versions fail.

Answer 11 · 2022-03-29T16:12:32.000Z

should be related to #101

Answer 12 · 2022-03-29T16:26:55.000Z

Sorry, it still error https://github.com/JounQin/remark-preset-prettier/runs/5740767638?check_suite_focus=true

Answer 13 · 2022-06-26T09:27:57.000Z

Maybe related to extends node_modules json with same name dir like privatenumber/get-tsconfig@532bee9 (#21)