Definition for rule not found
XhmikosR opened this issue · 5 comments
Hello!
I decided to give the package a go for our v4-dev branch and I'm just getting "Definition for rule "foo" not found".
I see you're using:
"eslint-plugin-qunit": "git+https://github.com/platinumazure/eslint-plugin-qunit.git#master"
Just to verify, does "eslint-plugin-qunit": "^5.0.0" have the same result?
You could also try adding "plugins": ["qunit"] to your .eslintrc.json. If this fixes it, @platinumazure we could add this to the recommended config itself so consumers don't have to specify it.
You could also try adding
"plugins": ["qunit"]to your.eslintrc.json. If this fixes it, @platinumazure we could add this to therecommendedconfig itself so consumers don't have to specify it.
@bmish Good idea in principle, but I don't know what happens if both the extended config and the consuming config have plugins entries. Would they be unioned together or would the consuming config override the plugins entry completely? If the latter, there is next to no point in giving our config a plugins entry.
That said, we definitely should spell out the need to include this as a plugin entry in our Getting Started guide. If that's not spelled out already, I would definitely accept a PR to make that part clear.
@platinumazure plugins will be unioned together. You can see that many popular eslint plugins specify their own plugin in their configs for convenience:
Just to verify, does
"eslint-plugin-qunit": "^5.0.0"have the same result?
This is the second of the 2 patches, both fail with the same error, unfortunately.
You could also try adding
"plugins": ["qunit"]to your.eslintrc.json. If this fixes it, @platinumazure we could add this to therecommendedconfig itself so consumers don't have to specify it.
Yeah, that works. Should definitely be documented. :)