playframework/play-samples

Replace netty default settings with akka HTTP

ignasi35 opened this issue · 2 comments

ignasi35 commented

Some samples (https://github.com/playframework/play-samples/blob/2.7.x/play-java-starter-example/conf/application.conf#L149-L159) still provide scaffolding settings for the Netty HTTP backend. These should be replaced with Akka-http settings.

marcospereira commented

Fixed by #66. Not sure why it was not closed when merging the PR. 🤔

dwijnand commented

Because 2.7.x is the default branch. Any PR that fixes an issue but isn't merged into the default branch doesn't auto-close tickets.

  • 👍1