pleriche/FastMM4

Magic Numbers

maximmasiutin opened this issue · 3 comments

maximmasiutin commented

There are some Magic Numbers in FastMM4

https://en.wikipedia.org/wiki/Magic_number_(programming)#Unnamed_numerical_constants

For a single author, it is OK, but for a public open source code -- I think we should little by little name them.

maximmasiutin commented

I've removed almost all magic numbers in the fork https://github.com/maximmasiutin/FastMM4-AVX

This fork is well-tested already, used in The Bat! email client www.ritlabs.com/en/products/thebat/ , and it is much faster.

  • 👍2
EMBBlaster commented

I've removed almost all magic numbers in the fork https://github.com/maximmasiutin/FastMM4-AVX

Shouldn't you do a Pull Request with this?

maximmasiutin commented

Unfortunately, there were no single commit with just magic numbers removed, the changes were very significant; namely, in alignment, in thread locking and in AVX instructions. So, there will be impossible to just make a pull request. But it will be possible to just compare the files and introduce the changes manually.