Unexpected comma and prenote position in \textcite

[moewew]

Consider the following MWE

\documentclass[british]{article}
\usepackage[T1]{fontenc}
\usepackage[utf8]{inputenc}
\usepackage{babel}
\usepackage{csquotes}

\usepackage[style=apa, backend=biber]{biblatex}

\addbibresource{biblatex-examples.bib}

\begin{document}
\textcite[see][380]{sigfridsson}

\printbibliography
\end{document}

see, Sigfridsson and Ryde (1998, p. 380)

The comma after "see" is unexpected given that \prenotedelim is \addspace.

The position of the "see" is also different from what the standard styles do, they would move the prenote into the parentheses

Sigfridsson and Ryde (see 1998, p. 380)

---

My guess for the culprit is

biblatex-apa/tex/latex/biblatex-apa/cbx/apa.cbx

Line 225 in 5c2f03a

\setunit{\compcitedelim}%

That \setunit may have to be guarded with a test to avoid it being called on the first citekey.

I can prepare a pull request (also for apa6, which has the same issues) if you confirm that the comma is unwanted and make a ruling on the position of the prenote (should it go before the \textcite or into the parentheses).

[moewew]

While we are at it: Do we need

biblatex-apa/tex/latex/biblatex-apa/bbx/apa6.bbx

Lines 85 to 96 in 409aef9

	%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
	% (APA 4.16 Example 29) Some DSM macros
	\gdef\DSMIII{\emph{DSM-III}}
	\gdef\DSMIIIR{\emph{DSM-III-R}}
	\gdef\DSMIV{\emph{DSM-IV}}
	\gdef\DSMIVTR{\emph{DSM-IV-TR}}
	\gdef\PsycSCAN{\emph{PsycSCAN}}
	\gdef\PsycARTICLES{\emph{PsycARTICLES}}
	%
	%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

If those definitions are needed, I'd definitely go with \newcommand instead of \gdef, but I doubt those commands are documented and used, so they can probably go...

[plk]

I think they can go - \gdef is certainly not good and I don't think they are used or documented.

[moewew]

Good. PR with that coming up (and something similar to 03063f1)