ploomber/sql

Fix linting issue - making your first query

Closed this issue · 3 comments

lfunderburk commented

Hi @jpjon

A new github action was setup to check for linting issues. Can you please open a new pr with the content of your "making a first query" file, add a test commit and push to trigger the linting action, and check for any errors you are getting when building the docs

For example, for the "except" issue it is raising, one fix is to add

In this case it is worth asking whether we want to keep the try-except clause for an installation

try:
    %pip install jupysql --upgrade duckdb-engine pandas --quiet
    print("Success")
except Exception as e:
    print(f"Eetry installing. Error {e}")

I am leaning towards no

lfunderburk commented

In your PR, you will be able to see this in the "checks" tab

image

I will work on fixing the ones in my EDA notebook and share an update

lfunderburk commented

Closing as it was fixed - it was my code snippet with the try except that created issues