plouc/go-gitlab-client

id type mismatch.

euforia opened this issue · 2 comments

euforia commented

It seems Gitlab emits an event with the project_id as an int64, but the AddProjectWebhook takes an id of type string https://github.com/plouc/go-gitlab-client/blob/master/hooks.go#L91

Any particular reason why it was done this way or can I go ahead and do a PR with the fix?

fudanchii commented

I was hoped the comment there is clear though, as specified at gitlab documentation: https://github.com/gitlabhq/gitlabhq/blob/7-11-stable/doc/api/projects.md

the id is supposed to be either project_id or a composed namespace/project_name so using string here is, I believe, make sense.
Using int64 will break the support for specifying id as namespace/project_name.

euforia commented

Ah ok. Makes a lot more sense. I was unaware of the fact that the namspaced path could be used as the id. Thank you for the clarification.