pluginpal/strapi-plugin-config-sync

Plugin is failing when clean and build after strapi upgrade

Closed this issue · 9 comments

saifmattias commented

Bug report

Getting ModuleNotFoundError when building the plugin with strapi 4.0.3

Describe the bug

ModuleNotFoundError: Module not found: Error: Can't resolve 'immutable' in '/node_modules/strapi-plugin-config-sync/admin/src/helpers'

I am getting this when trying to build after the upgrade for strapi 4.0.3
A clear and concise description of what the bug is.

Steps to reproduce the behavior

  1. Upgrade strapi to 4.0.3
  2. Run npm run build --clean
  3. The error shows up

Expected behavior

Run run build without error

System

  • Node.js version: Tested with version 14 (npm v8.3.0) and 16 (npm v8.1.0)
  • Strapi version: 4.0.3
  • Plugin version: 1.0.0-beta.1
  • Database: Postgressql
  • Operating system: locally
boazpoolman commented

That’s weird. I’ll check it out.
Thanks for submitting the issue.

du0ngtrunghieu commented

I also have the same problem, hope you fix it as soon as possible

System
Strapi version: 4.0.3
Plugin version: 1.0.0-beta.1
Database: Postgressql
Operating system: heroku

boazpoolman commented

So it seems Strapi has removed immutable and redux-immutable as dependencies since 4.0.3.
This plugin relied on those, so I've added them as direct dependencies of the plugin.

Thanks again for the quick issue submissions!

Should be fixed in v1.0.0-beta.2

mlouage commented

Hi @boazpoolman . Still getting that error with beta.2. I also use Postgres as the database.

❯ yarn cs export
yarn run v1.22.17
$ config-sync export
/home/<username>/Play/strapi-postgresql/cms/node_modules/strapi-plugin-config-sync/server/cli.js:163
program.storeOptionsAsProperties(false).allowUnknownOption(true);
        ^

TypeError: program.storeOptionsAsProperties is not a function
boazpoolman commented

Oh wtf, this is a different issue.
Just tested it though, didn't have any issues.

Thanks. I'll take a look.

mlouage commented

Oops, you're right. Sorry, must have been in a hurry to miss that. Thanks!

boazpoolman commented

@mlouage just tested it, works fine on my end.
Can you maby create a new issue following the issue template?
Providing system versions etc :)

  • 👍1
boazpoolman commented

@du0ngtrunghieu or @saifmattias
Can one of you confirm that v1.0.0-beta.3 fixes the initial issue?

boazpoolman commented

It's been a week, and I'm pretty sure this has been fixed.

I'm closing the issue now.