pluginpal/strapi-plugin-config-sync

Replace "react-diff-viewer" dependency with "react-diff-viewer-continued"

tadwohlrapp opened this issue · 3 comments

tadwohlrapp commented

Bug report

Describe the bug

I get the following warnings when installing strapi-plugin-config-sync:

warning "strapi-plugin-config-sync > react-diff-viewer@3.1.1" has incorrect peer dependency "react@^15.3.0 || ^16.0.0".
warning "strapi-plugin-config-sync > react-diff-viewer@3.1.1" has incorrect peer dependency "react-dom@^15.3.0 || ^16.0.0".

react-diff-viewer seems to be abandoned (last update was in May 2020) and there is a successor fork called react-diff-viewer-continued (npm package).

Steps to reproduce the behavior

  1. Use yarn
  2. Have a React version higher than v16.x installed (or no React installed, which would cause a has unmet peer dependency warning)
  3. Run yarn add strapi-plugin-config-sync
  4. See error

Expected behavior

Use currently maintained dependencies which don't cause warnings

Screenshots

image

System

  • Node.js version: 16.18.0 LTS
  • NPM version: 8.19.2
  • Strapi version: 4.4.7
  • Plugin version: 1.0.4
  • Database: SQLite
  • Operating system: macOS
boazpoolman commented

Excellent suggestion. It makes sense to switch to the new package.

  • ❤️1
boazpoolman commented

Made the change directly on the master branch. See commit.
I'll release it with the next release of the plugin :)

boazpoolman commented

This was released with v1.1.0 of the plugin.

  • ❤️1