We should decode generic WAP pushes
andrewbird opened this issue · 6 comments
We should be able to decode generic WAP pushes so that we can test the content type properly. Currently we assume that all WAP pushes are MMS notifications, which obviously isn't true.
Yeah, do you have any sample data to work on it?
yep, see the PDU / decoded string in 'test_wap::test_decoding_generic_wap_push' this is a WAP push, but not a MMS notification
BTW checkout the pydump procedure I added to the resources directory, you can use it to utilise wireshark for decoding.
This is a fairly complex ticket :) Guess we'd need to add a wbxml decoder, what do you think? The only one available uses a libwbxml with pyrex, but I'd prefer to remain a pure python project. What do you reckon andrew?
From my personal point of view I'd be happy if we (read you, as it needs lots of python foo!) could refactor so that the MMS is a subclass of a new WAP push class. In the short term I'm not worried about proper interpretation of generic WAP pushes only enough so that I can decode the type and give a sane implementation of the is_mms_notification() I added.
Ok, will create a branch for it this weekend and we can work on it.
On Wed, Jun 15, 2011 at 7:29 PM, andrewbird
reply@reply.github.com
wrote:
From my personal point of view I'd be happy if we (read you, as it needs lots of python foo!) could refactor so that the MMS is a subclass of a new WAP push class. In the short term I'm not worried about proper interpretation of generic WAP pushes only enough so that I can decode the type and give a sane implementation of the is_mms_notification() I added.
Reply to this email directly or view it on GitHub:
#10 (comment)
Pablo Martí
http://www.linkedin.com/in/pmarti
python -c "print '706d617267616d40676d61696c2e636f6d'.decode('hex')"