py3k support is partially broken
pmarti opened this issue · 2 comments
pmarti commented
The fix for 7bit decoding broke py3k support:
test_encoding_multipart_7bit (messaging.test.test_encoding.TestEncodingFunctions) ... Traceback (most recent call last):
File "/home/pablo/devel/git/python-messaging/build/lib.linux-i686-3.1/messaging/gsm0338.py", line 395, in is_valid_gsm_text
text.encode("gsm0338")
TypeError: encoder did not return a bytes object (type=str)
pmarti commented
12/19 tests are not working, mostly due to
Traceback (most recent call last):
File "/home/pablo/devel/git/python-messaging/build/lib.linux-i686-3.1/messaging/test/test_decoding.py", line 51, in test_decoding_datetime_gmtplusone
ret = self.pdu.decode_pdu(pdu)
File "/home/pablo/devel/git/python-messaging/build/lib.linux-i686-3.1/messaging/pdu.py", line 294, in decode_pdu
msg = msg.decode("gsm0338")
AttributeError: 'str' object has no attribute 'decode'
Which was introduced in f154337