pmint93/helm-charts

Support for ingressClassName

Closed this issue · 1 comments

Newer versions of kubernetes allow specifying the ingressClassName directly on the ingress spec as opposed to an annotation which is now deprecated.

Here's what I mean

Shall I make a PR for this?

IngressClass resource and ingressClassName field were added in v1.18. So I think if there is PR for this, we should keep the chart compatible with the older versions, which mean ingressClassName should only be generated when deploy to kubernetes cluster >= v1.18 ?

Shall I make a PR for this?

Yes, It would be great !