pmint93/helm-charts

feat: support `ServiceMonitor`

Closed this issue · 2 comments

jjangga0214 commented

Hi!

Currently, it provides monitoring.enabled value.
However, ServiceMonitor resource for Prometheus is not provisioned.
I think it's great option.

How do you think?

Thank you very much for this chart.

Sincerely,

pmint93 commented

@jjangga0214 Agree, but serviceMonitor should be configured with difference option than monitoring.enabled because of not everyone use prometheus operator

jjangga0214 commented

@pmint93 Exactly. That's the convention as well. monitoring.serviceMonitor.enabled would be cool.

  • 👍2