Test suite is currently broken (master)

Question

Test suite is currently broken (master)

TimvanScherpenzeel opened this issue 4 years ago · 8 comments

TimvanScherpenzeel commented 4 years ago

The recently added isSSR option caused the test suite to break.

Declaring

/**
 * @jest-environment jsdom
 */

at the top of the file raises other issues.

Answer 1 · 2021-06-07T08:42:29.000Z

Special cases to account for:

Answer 2 · 2021-06-13T16:53:16.000Z

I'm not sure how to check #62 #57 #56 other then that the benchmark has been updated and the 2 NVIDIA's issues should be resolved.

Answer 3 · 2021-06-13T17:00:59.000Z

#62 and #57 are resolved with the new benchmarks. #56 appears to be a different issue. With iOS devices we rely on floating point precision in the shader (which is determined by the hardware) and some other features such as DPI and resolution to determine which iOS device it might be.

Answer 4 · 2021-06-13T17:01:57.000Z

AKA - that will require some debugging with that exact device.

Answer 5 · 2021-06-13T17:02:58.000Z

Correct, I hope @puckey would have time to pick this one up. I wouldn't consider #56 as blocker for release.

Answer 6 · 2021-06-13T17:04:33.000Z

Got it. The tests are fixed the benchmark is updated(especially for 30x series). Seems good enough for a 3.1 release

Answer 7 · 2021-06-13T17:23:38.000Z

I've released version 3.1.0 on NPM (https://www.npmjs.com/package/detect-gpu/v/3.1.0) with the updated benchmarks and your PR's - thanks!

Answer 8 · 2021-06-13T17:24:39.000Z

Happy to help out!