pmndrs/react-spring

Fails to install on Yarn 3

alvarlagerlof opened this issue · 13 comments

alvarlagerlof commented

🐛 Bug Report

Current react spring does not install on Yarn 3.1.0 on a minimal project

To Reproduce

  1. npm install -g yarn
  2. Create a empty directory
  3. yarn set version berry
  4. yarn add react-spring

Expected behavior

React spring installs without issues.

Link to repro (highly encouraged)

Needs CLI

Environment

  • react-spring v9.3.0
joshuaellis commented

Thanks for the report! this is a duplicate of #1668

alvarlagerlof commented

@joshuaellis I don't believe it is. Sorry for not providing CLI output before. This one seems more related to react-spring.

➤ YN0000: ┌ Resolution step
➤ YN0002: │ react-spring@npm:9.3.0 doesn't provide @react-three/fiber (pb91c8), requested by @react-spring/three
➤ YN0002: │ react-spring@npm:9.3.0 doesn't provide konva (pe619c), requested by @react-spring/konva
➤ YN0002: │ react-spring@npm:9.3.0 doesn't provide react (pac595), requested by @react-spring/core
➤ YN0002: │ react-spring@npm:9.3.0 doesn't provide react (pf7cd9), requested by @react-spring/konva
➤ YN0002: │ react-spring@npm:9.3.0 doesn't provide react (pda097), requested by @react-spring/native
➤ YN0002: │ react-spring@npm:9.3.0 doesn't provide react (pe6c53), requested by @react-spring/three
➤ YN0002: │ react-spring@npm:9.3.0 doesn't provide react (p3668a), requested by @react-spring/web
➤ YN0002: │ react-spring@npm:9.3.0 doesn't provide react (p44ae1), requested by @react-spring/zdog
➤ YN0002: │ react-spring@npm:9.3.0 doesn't provide react-dom (pea721), requested by @react-spring/web
➤ YN0002: │ react-spring@npm:9.3.0 doesn't provide react-dom (pe22c1), requested by @react-spring/zdog
➤ YN0002: │ react-spring@npm:9.3.0 doesn't provide react-konva (pbdfb4), requested by @react-spring/konva
➤ YN0002: │ react-spring@npm:9.3.0 doesn't provide react-native (p3eb33), requested by @react-spring/native
➤ YN0002: │ react-spring@npm:9.3.0 doesn't provide react-zdog (p22cb6), requested by @react-spring/zdog
➤ YN0002: │ react-spring@npm:9.3.0 doesn't provide three (pf3bcb), requested by @react-spring/three
➤ YN0002: │ react-spring@npm:9.3.0 doesn't provide zdog (p1f667), requested by @react-spring/zdog
➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code
➤ YN0000: └ Completed
➤ YN0000: ┌ Fetch step
➤ YN0000: └ Completed
➤ YN0000: ┌ Link step
➤ YN0007: │ @react-spring/core@npm:9.3.0 [cd765] must be built because it never has been before or the last one failed
➤ YN0009: │ @react-spring/core@npm:9.3.0 [cd765] couldn't be built successfully (exit code 1, logs can be found here: /tmp/xfs-72db173b/build.log)
➤ YN0000: └ Completed in 0s 245ms
➤ YN0000: Failed with errors in 0s 345ms
QuiiBz commented

@joshuaellis I don't believe it is. Sorry for not providing CLI output before. This one seems more related to react-spring.

➤ YN0000: ┌ Resolution step
➤ YN0002: │ react-spring@npm:9.3.0 doesn't provide @react-three/fiber (pb91c8), requested by @react-spring/three
➤ YN0002: │ react-spring@npm:9.3.0 doesn't provide konva (pe619c), requested by @react-spring/konva
➤ YN0002: │ react-spring@npm:9.3.0 doesn't provide react (pac595), requested by @react-spring/core
➤ YN0002: │ react-spring@npm:9.3.0 doesn't provide react (pf7cd9), requested by @react-spring/konva
➤ YN0002: │ react-spring@npm:9.3.0 doesn't provide react (pda097), requested by @react-spring/native
➤ YN0002: │ react-spring@npm:9.3.0 doesn't provide react (pe6c53), requested by @react-spring/three
➤ YN0002: │ react-spring@npm:9.3.0 doesn't provide react (p3668a), requested by @react-spring/web
➤ YN0002: │ react-spring@npm:9.3.0 doesn't provide react (p44ae1), requested by @react-spring/zdog
➤ YN0002: │ react-spring@npm:9.3.0 doesn't provide react-dom (pea721), requested by @react-spring/web
➤ YN0002: │ react-spring@npm:9.3.0 doesn't provide react-dom (pe22c1), requested by @react-spring/zdog
➤ YN0002: │ react-spring@npm:9.3.0 doesn't provide react-konva (pbdfb4), requested by @react-spring/konva
➤ YN0002: │ react-spring@npm:9.3.0 doesn't provide react-native (p3eb33), requested by @react-spring/native
➤ YN0002: │ react-spring@npm:9.3.0 doesn't provide react-zdog (p22cb6), requested by @react-spring/zdog
➤ YN0002: │ react-spring@npm:9.3.0 doesn't provide three (pf3bcb), requested by @react-spring/three
➤ YN0002: │ react-spring@npm:9.3.0 doesn't provide zdog (p1f667), requested by @react-spring/zdog
➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code
➤ YN0000: └ Completed
➤ YN0000: ┌ Fetch step
➤ YN0000: └ Completed
➤ YN0000: ┌ Link step
➤ YN0007: │ @react-spring/core@npm:9.3.0 [cd765] must be built because it never has been before or the last one failed
➤ YN0009: │ @react-spring/core@npm:9.3.0 [cd765] couldn't be built successfully (exit code 1, logs can be found here: /tmp/xfs-72db173b/build.log)
➤ YN0000: └ Completed in 0s 245ms
➤ YN0000: Failed with errors in 0s 345ms

You can cat /tmp/xfs-72db173b/build.log to see if it's the same error, but I think it is, I'm having the same.

joshuaellis commented

Gonna be honest, i'm still using yarn 1.X why? because I've always found yarn's error messages to be cryptic and it never just works. However, can I ask if you've:

  • tried to just install a particular target i.e @react-spring/web
  • asked in the yarn repo? Feels weird I can install it with other package managers and have no issues.
QuiiBz commented

As you mentioned, this is an issue in yarn v3:

An existing fix is to skip the build of @react-spring/core as shown here:

joshuaellis commented

I think that error report from yarn would help me understand if this is a duplicate or a different issue

alvarlagerlof commented

You can cat /tmp/xfs-72db173b/build.log to see if it's the same error, but I think it is, I'm having the `same.

Right, I see now that it is the same error. Sorry for not realizing that.

# This file contains the result of Yarn building a package (@react-spring/core@virtual:cd7650f55e82fb441490c229ae2e73dde3c2a0e29ca9735f6a3a202375f9c134ab1778ff954307c5c379dc519bd09b5a2ccc8cd7f3964b712fac8baf9897ff04#npm:9.3.0)
# Script name: postinstall

[eval]:1
console.log('Enjoy react-spring? You can now donate to our open collective:
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

SyntaxError: Invalid or unexpected token
    at new Script (node:vm:100:7)
    at createScript (node:vm:257:10)
    at Object.runInThisContext (node:vm:305:10)
    at node:internal/process/execution:81:19
    at [eval]-wrapper:6:22
    at evalScript (node:internal/process/execution:80:60)
    at node:internal/main/eval_string:27:3

tried to just install a particular target i.e @react-spring/web

I did try that now, and it seems to fail too.

❯ yarn add @react-spring/web
➤ YN0000: ┌ Resolution step
➤ YN0002: │ root-workspace-0b6124@workspace:. doesn't provide react (p22964), requested by @react-spring/web
➤ YN0002: │ root-workspace-0b6124@workspace:. doesn't provide react-dom (p97098), requested by @react-spring/web
➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code
➤ YN0000: └ Completed in 3s 574ms
➤ YN0000: ┌ Fetch step
➤ YN0013: │ @react-spring/core@npm:9.3.0 can't be found in the cache and will be fetched from the remote registry
➤ YN0013: │ @react-spring/rafz@npm:9.3.0 can't be found in the cache and will be fetched from the remote registry
➤ YN0013: │ @react-spring/shared@npm:9.3.0 can't be found in the cache and will be fetched from the remote registry
➤ YN0013: │ @react-spring/types@npm:9.3.0 can't be found in the cache and will be fetched from the remote registry
➤ YN0013: │ @react-spring/web@npm:9.3.0 can't be found in the cache and will be fetched from the remote registry
➤ YN0000: └ Completed
➤ YN0000: ┌ Link step
➤ YN0007: │ @react-spring/core@npm:9.3.0 [40ba1] must be built because it never has been before or the last one failed
➤ YN0009: │ @react-spring/core@npm:9.3.0 [40ba1] couldn't be built successfully (exit code 1, logs can be found here: /tmp/xfs-4b2129c8/build.log)
➤ YN0000: └ Completed in 0s 305ms
➤ YN0000: Failed with errors in 3s 983ms

This did work

An existing fix is to skip the build of @react-spring/core as shown here:

shadowbrush commented

Why was this issue closed? It's still broken in 9.3.0.

alvarlagerlof commented

@shadowbrush yarnpkg/berry#1356 is the real issue so better to comment there.

  • 👍1
MarcCelani-at commented

We have a pretty big, complex mono-repo, and this is the only package that is tickling this bug. I get that yarn is the proper place to fix this, but isn't it relatively simple to fix this within react-spring? I wasted quite a bit of time on this.

joshuaellis commented

It was fixed in 9.3.1

mjsisley commented