pnarimani/RTLTMPro

RTL_OVERRIDE not set for 3D text

HamsterDinner opened this issue · 2 comments

Was having some issues with the plugin and traced it down to RTLTextMeshPro3D.cs having the #define RTL_OVERRIDE disabled and so was not overriding text. I was referencing an element with TMP_Text and so it used the original version of text rather than the one in RTLTextMeshPro3D and so failed in this case.
I re-enabled the override and it seems to fix it so am just wondering if there will be anything unexpected from enabling this? The canvas version overrides (with a test on #if TMP_VERSION_2_1_0_OR_NEWER) and so there were no problems there. Should that be the same in the 3D one?

This is terrible x(
It seems that the 3D version is missing some recent fixes. 3D should match the UGUI version.
You are on the right track, That #if TMP_VERSION_2_1_0_OR_NEWER directive should fix it as far as I can tell.
I'll make a fix today.

commit #60c8973