meta: HiOp 1.0.1+ suport
cameronrutherford opened this issue · 4 comments
There are many moving parts here, and so I am creating a new issue to track all these components, and to determine the right order to operations.
Here are the current list of relevant issues (with related PRs):
- #46 (@nychiang you need to verify this issue still exists and provide a reproducer before we can merge)
- #28 (@nychiang reported this, but I assume these will appear in CI when we attempt an upgrade. #30 partially addresses this)
- #3 (See #2 by @jaelynlitz - this was a HiOp side issue that should be fixed in future releases)
- #43 (unsure about this, but assume #3 is related to this)
- #31 (this isn't explicitly
hiop@1.0.1or any version, but seems related)
We will likely need a larger PR to address all of these issues somehow, but the hope is that they can all be resolved together.
@cameronrutherford should I try to use the latest develop branch, or release 1.6.0?
@cameronrutherford should I try to use the latest develop branch, or release 1.6.0?
We will need some patches merged into ExaGO to fix this, so definitely develop. We will then have a PR with working changes + latest HiOp running tests on all platforms
@jaelynlitz @cameronrutherford I filed a new PR in HiOp, to withdraw -Wall and -Werror in the RELEASE mode.
Therefore, I expect this can fix the compile warnings/errors you observed with unused variables.
@jaelynlitz just got back from vacation and is leading this, but that is helpful. We will generate new build with that PR and hopefully we can then re-add develop builds of hiop back with ExaGO.
We also need LLNL/hiop#669 merged in order to support #50 and latest Ginkgo release in ExaGO, so we may need to test experimental versions of HiOp in many places at once