The LICENSE is not clearly OSI compliant
drj11 opened this issue · 2 comments
drj11 commented
Describe the bug
LICENSE is provided in LICENSE.rst
but it not clearly OSI compliant.
Additional context
I am reviewing this package for JOSS openjournals/joss-reviews#6016 (comment)
It looks like the license is intended to be the BSD 3-clause license (at OSI here: https://opensource.org/license/bsd-3-clause/ ) but:
- there is a typo at the end of the 2nd clause which currently reads "and/or other" but should read "and/or other materials provided with the distribution."
- the third clause has been edited in a way as to make it unclear if it still matches the BSD 3-clause license. In particular "Neither the name of the copyright holder nor the names of its contributors may be used to endorse or promote products derived from this software" has been changed to "neither the name Battelle Memorial Institute or Battelle may be used in any form whatsoever without the express written consent of Battelle.".
The modification to clause 3 appears to be a substantial reduction in the grant.
I suggest that you either:
- use the BSD 3-clause license directly; or,
- provide enough material to reviewers to assure us that this license is in fact "the contents of an OSI approved software license"
danielskatz commented
For JOSS to review the work, it has to have an OSI-compliant license, which means that the license can't be a variation of an OSI license, but actually an OSI license.
brendapraggastis commented
@danielskatz @drj11 We updated the license to standard verbiage. Thanks for the catch.