HttpClient instantiated incorrectly in samples
kaevans opened this issue · 0 comments
kaevans commented
Category
[X ] Bug
[ ] Enhancement
Environment
[ X] Office 365 / SharePoint Online
[ X] SharePoint 2016
[ X] SharePoint 2013
Expected or Desired Behavior
Incorrect instantiation of HttpClient in samples.
See https://docs.microsoft.com/en-us/azure/architecture/antipatterns/improper-instantiation/ for an explanation of instantiating HttpClient within a method in a multi-threaded application.
Multiple instances of this found across samples in this repo.
https://github.com/SharePoint/PnP/search?q=new+httpclient&unscoped_q=new+httpclient
Observed Behavior
TCP resource exhaustion and application instability under load.
Steps to Reproduce
Load test a sample.