pnp/cli-microsoft365

Bug report: Spinner is visible in update message

Closed this issue · 2 comments

Priority

(Low) Something is a little off

Description

Spinner is printed in the notification to install a new update

image

Steps to reproduce

Let the update notification pop while spinner is enabled.the

Expected results

To see only the update notification without the spinner

Actual results

Spinner visisble

Diagnostics

No response

CLI for Microsoft 365 version

v7.5.0

nodejs version

v20.10.0

Operating system (environment)

Windows

Shell

PowerShell

cli doctor

No response

Additional Info

No response

Seems like this can be solved by changing the index.ts file to an async function which gets called at the end, awaiting both the import of the package notifier and the cli.execute statement. What do you think about that? I did some research, and this does not seem to impact the total performance of the cli, on the contrary, it sped it up just a few milliseconds strangely enough 😄

That will probably be the only way for the spinner not so show indeed.