pnp/cli-microsoft365

'spfx doctor' should support also gulp-cli v3

Closed this issue · 8 comments

Adam-it commented

So it seems currently in spfx doctor we validate if gulp-cli is either v1 or v2

image

if we check the spfx docs we will see the guide will actually install the latest gulp-cli which is v3

image

From what I checked SPFx should work properly with gulp-cli@3 and I got it confirmed from Alex as well.

Lets add this support

jasonmokk commented

Hello, I would like to work on this issue. Can you please assign it to me?

  • 🚀1
milanholemans commented

Definitely @jasonmokk, all yours!

  • 👍1
waldekmastykarz commented

@Adam-it, did you also learn starting from which version SPFx supports gulp-cli@3?

Adam-it commented

@Adam-it, did you also learn starting from which version SPFx supports gulp-cli@3?

From when it was released. So 3 months ago so the first version is 1.18 no sooner

waldekmastykarz commented

@Adam-it, did you also learn starting from which version SPFx supports gulp-cli@3?

From when it was released. So 3 months ago so the first version is 1.18 no sooner

I suggest that we don't make assumptions and instead check with Alex

  • 👍2
Adam-it commented

sure thing. I pinged Alex. Will keep you updated 👍

Adam-it commented

@waldekmastykarz after rediscussing this topic with Alex and rechecking it myself we agreed it's best to add gulp-cli@3 only for SPFx 1.19.0 and later versions.

  • 👍1
waldekmastykarz commented

Thank you for confirming @Adam-it