poanetwork/blockscout-terraform

Change sequence of deployment script: set env vars -> compile

vbaranov opened this issue · 5 comments

vbaranov commented

Some ENV vars are used in compilation time (see blockscout/blockscout#2577 for the reference). Thus, the correct sequence in the deployment script should be: set env vars -> compile (and not vise-versa)

ArseniiPetrovich commented

Looks like the issue is already fixed in master with the recent PR, closing for now.
@vbaranov

vbaranov commented

@ArseniiPetrovich could you provide the code lines where compilation and env vars set does take place? I already tried to deploy some instances a while ago from master and the issue that misorder causes didn't resolve.

ArseniiPetrovich commented

Sure, @vbaranov
Please, check

blockscout-terraform/roles/main_software/tasks/main.yml

Line 133 in e2e8326

environment: "{{ server_env }}"

Also I tried it manually and it seems to be working for me.

ArseniiPetrovich commented

@ayrat555 I don't think this is necessary. Deployment scripts delete and re-pull BS repo each time we run the deployment process unless the skip_fetch is not set to true