poblabs/weewx-belchertown

jQuery UI is loaded, but is it really used?

Closed this issue · 4 comments

💡 The Idea
In header.html.tmpl I find a reference to jQuery-UI:

  • line 79
    <link rel="stylesheet" href="//ajax.googleapis.com/ajax/libs/jqueryui/1.12.1/themes/smoothness/jquery-ui.css">
    
  • line 100
    <script type='text/javascript' src="//ajax.googleapis.com/ajax/libs/jqueryui/1.12.1/jquery-ui.min.js"></script>
    

The Google website check listed it as problem.

I commented it out, and I found no difference in behavior.

So I guess it could be removed.

🔨 Breaking Feature
None, I hope

HELP WANTED
I can send a PR if necessary.

If I recall, jquery-ui is used for modal for the almanac popup

The almanac modal window works fine without jQery-UI. You can check it here:
Website with jQuery-UI commented out

I checked the source code for the modal popups. The classes used there are defined in bootstrap.min.css.

@roe-dl thanks, that's 290kb less to load !