pocketzeroes/pipeviewer

Integrate patch for "-m" (block/line mode)

GoogleCodeExporter opened this issue · 4 comments

Integrate attached patch from E. Rosten.

Original issue reported on code.google.com by ivarch...@gmail.com on 14 Dec 2010 at 2:31

Attachments:

Here is an updated patch (in unified diff mode) for pv version 1.2.0.

Please please can we integrate this. pv's -l performance is absolutely 
horrible, but without that it's of little use for most shell pipes.

Thanks!

Original comment by jbarb...@gmail.com on 8 May 2011 at 11:49

Attachments:

Sorry, I missed a break statement in that patch, so it won't run correctly.

Enclosed is a patch which fixes that, but also fixes progress bar (so that the 
rate is still shown as by line). It does this by searching through the written 
buffer to get the count of new lines (much as linemode does).

Again thanks for the wonderful pv. I'll continue to run with this patch until 
it's in the main tree though.

Original comment by jbarb...@gmail.com on 9 May 2011 at 12:32

Attachments:

Removing from Google Code as this is no longer an active platform for this 
project.

Original comment by ivarch...@gmail.com on 26 Aug 2014 at 10:11

  • Changed state: Done
Thanks for the patch - I'll have a look when I get a chance and see about 
getting it into the code.

Original comment by ivarch...@gmail.com on 11 Jul 2011 at 10:17