[Small Bug] DeviceDetector::full_version is returning platform version for Client Hints
Closed this issue · 1 comments
CosmicWolfe commented
Encountered a small bug while playing around with user agent client hints. (should be a one-line change)
The full_version
method in DeviceDetector is calling client_hint.platform_version
, which is the property used to get the os version.
It should be client_hint.full_version
instead. This is the browser version. (the one that read from the Sec-CH-UA-Full-Version header)
Let me know if you need more information!
CosmicWolfe commented
A related issue is that according to this, the Sec-CH-UA-Full-Version header will be deprecated in favor of Sec-CH-UA-Full-Version-List, which is similar to the Sec-CH-UA header, except it gives the full version for each brand instead of just the significant version.