podigee/device_detector

Last regexes and fixtures for device-detector, tests not passing

Closed this issue · 3 comments

rporrasluc commented

Hello, due to the number of changes in the device-detector original library, even if I run the rake tasks for updating the YAML files, the tests do not pass.

I have seen that some fixes have been added to the library so that is presumably the reason why the tests do not pass. I tried to change some results expected as "" but returned as nil and vice versa, but I could not get all the tests passed, so I think the best would be to start adding those fixes to this Ruby implementation of the library.

I am willing to contribute, I will start adding some pull requests.

Thanks and congratulations for the excellent library.

misner commented

+1 , see #39. would love but don't have the level sufficient to help.

matisojka commented

Solved in 5cdc27c

  • 👍1
  • ❤️1
rporrasluc commented

Thanks a lot @YAGoOaR, I can now use your version instead of my forked branch. Really appreciate your work. If I can help with something just let me know.

  • 👍1