podigee/device_detector

Use RuboCop?

Closed this issue · 2 comments

utkarsh2102 commented

Hi @spiderpug,

Thanks for maintaining this so far!
However, there are a bunch of things that could be fixed according to the Ruby style guide.

Would you consider using RuboCop?
I would be happy to raise a PR if so :)

spiderpug commented

Thank you for your suggestion.

We use Rubocop internally as well so I added some rules and adjusted the models in fad9de5 .

utkarsh2102 commented

Hi @spiderpug,

Thanks! Could you also update RuboCop to v0.89? I can make a PR too, let me know!