pog87/PtitPrince

AttributeError: module 'numpy' has no attribute 'asscalar'

arnavgarg1 opened this issue · 6 comments

I'm running into the following error when trying both pt.half_violinplot and pt.RainCloud. It seems to be related to the numpy version.

I'm currently on Numpy 1.23.1, so not sure if there's an issue here - are you able to take a look?

Thanks in advance!

Seems like it requires a pretty simple change: https://numpy.org/doc/1.21/reference/generated/numpy.asscalar.html to just use numpy.ndarray.item() instead of np.asscalar

I tried this locally and it seems to work without issues :)

pog87 commented

I'd be more than happy to review a pull request. thank you for helping!

Great, no problem! Here's the PR: #28

Once this is merged in, is it also possible to release a new version of this package to PyPI so the latest changes can be installed via pip install ptitprince? It seems like the last release was in September 2020!

pog87 commented

thank for your contribution!