polardb/polardbx-engine

‘TRUE’ was not declared in this scope

hiseeyoulater opened this issue · 3 comments

The lastest commit log is

commit 99986fccd58f8bdad0c59145a122ace52a812338 (HEAD -> main, origin/main, origin/HEAD)
Author: zhanfeng.mzf@alibaba-inc.com <zhanfeng.mzf@alibaba-inc.com>
Date:   Wed Oct 20 20:21:19 2021 +0800

    [Bugfix] Fix build warning

The error message of make -j8 is

[ 78%] Building CXX object sql/CMakeFiles/sql_main.dir/trans_proc/implicit_savepoint.cc.o
In file included from /home/ubuntu/develop/galaxyengine/include/template_utils.h:28:0,
                 from /home/ubuntu/develop/galaxyengine/include/m_ctype.h:46,
                 from /home/ubuntu/develop/galaxyengine/sql/sql_parse.h:30,
                 from /home/ubuntu/develop/galaxyengine/sql/trans_proc/implicit_savepoint.cc:21:
/home/ubuntu/develop/galaxyengine/sql/trans_proc/implicit_savepoint.cc: In member function ‘virtual bool im::Sql_cmd_trans_proc_implicit_savepoint::pc_execute(THD*)’:
/home/ubuntu/develop/galaxyengine/sql/trans_proc/implicit_savepoint.cc:59:17: error: ‘TRUE’ was not declared in this scope
     DBUG_RETURN(TRUE);
                 ^
/home/ubuntu/develop/galaxyengine/include/my_dbug.h:156:13: note: in definition of macro ‘DBUG_RETURN’
     return (a1);                              \
             ^~
/home/ubuntu/develop/galaxyengine/sql/trans_proc/implicit_savepoint.cc:65:17: error: ‘TRUE’ was not declared in this scope
     DBUG_RETURN(TRUE);

We have fixed TRUE/FALSE compile problem, reopen it if any problem again.

still the same error

[ 78%] Building CXX object sql/CMakeFiles/sql_main.dir/sys_vars.cc.o
In file included from /home/ubuntu/develop/galaxyengine/sql/sys_vars.cc:44:0:
/home/ubuntu/develop/galaxyengine/sql/sys_vars.cc:6785:66: error: ‘FALSE’ was not declared in this scope
     SESSION_ONLY(sequence_read_skip_cache), NO_CMD_LINE, DEFAULT(FALSE),
                                                                  ^
/home/ubuntu/develop/galaxyengine/sql/sys_vars.h:102:20: note: in definition of macro ‘DEFAULT’
 #define DEFAULT(X) X
                    ^
/home/ubuntu/develop/galaxyengine/sql/sys_vars.cc:6785:66: note: suggested alternative: ‘FILE’
     SESSION_ONLY(sequence_read_skip_cache), NO_CMD_LINE, DEFAULT(FALSE),
                                                                  ^
/home/ubuntu/develop/galaxyengine/sql/sys_vars.h:102:20: note: in definition of macro ‘DEFAULT’
 #define DEFAULT(X) X
                    ^
/home/ubuntu/develop/galaxyengine/sql/sys_vars_ext.cc:263:48: error: ‘FALSE’ was not declared in this scope
                                        DEFAULT(FALSE), NO_MUTEX_GUARD,
                                                ^
/home/ubuntu/develop/galaxyengine/sql/sys_vars.h:102:20: note: in definition of macro ‘DEFAULT’
 #define DEFAULT(X) X