The logic to calculate `fundsFree`

Question

The logic to calculate `fundsFree`

Closed this issue 5 months ago · 5 comments

https://github.com/paritytech/polkadot-staking-dashboard/blob/14188991f201ffd78cb704eae68c6e5a29e7c960/src/pages/Overview/BalanceChart.tsx#L111-L121

Here fundsReserved is already plankToUnit.

But allTransferOptions.freeBalance is not.
How can we do math between plankToUnit and plank?

https://github.com/paritytech/polkadot-staking-dashboard/blob/14188991f201ffd78cb704eae68c6e5a29e7c960/src/pages/Overview/BalanceChart.tsx#L115-L116

This does not make sense.

Answer 1 · 2024-04-09T10:57:44.000Z

https://github.com/paritytech/polkadot-staking-dashboard/blob/14188991f201ffd78cb704eae68c6e5a29e7c960/src/contexts/TransferOptions/index.tsx#L56-L76

I noticed that allTransferOptions.freeBalance is already deducted by feeReserve & edReserve

Answer 2 · 2024-04-09T11:55:51.000Z

@rossbulat Please review this.
This is from my understanding. I want to know if I'm on the correct way
#2075

Answer 3 · 2024-04-11T14:46:15.000Z

Thanks @frankli-dev, there was an issue I identified regarding the reserved value thanks to your investigation.

Answer 4 · 2024-04-11T14:59:51.000Z

fundsFree and freeBalance are 2 different values. fundsFree does not take into consideration other locks on the account E.g. OpenGov locks, whereas freeBalance only takes into consideration the staking lock. This is indeed confusing and could well be improved.

Answer 5 · 2024-04-11T15:08:13.000Z

Fixed in #2075