polkadot-evm/frontier

Why `pallet-evm` requires `serde`

lemunozm opened this issue · 0 comments

Question

Hi, I want to ask why from polkadot-v1.0.0 you've added the serde feature here: https://github.com/polkadot-evm/frontier/blob/polkadot-v1.0.0/frame/evm/Cargo.toml#L34

This addition makes internally compile sp-runtime with serde, and the MaybeSerializeDeserialize and MaybeSerialize traits now force always to be Serialize. This means that all types in our project now require to be Serialize when it was not required before. It seems like a big change, and I would want to know the reason behind this.

Compiling pallet-evm removing the above requirement compiles without failures. Could that addition be a typo?

Thanks so much!